I made a new site but when I create a new user and login I am not able to see any products?

The new user is likely not part of any site groups that are able to see the products on your site. Since products are set to be visible based on site group, and since products have pricing assigned based on site group, you'll need to make sure that any new users are getting assigned to the appropriate site groups to be able to see content on your site.
You will want to check the new user defaults that get assigned to any new users you create on a site. Go to the site menu to User Management > Site Users, click the gear icon at the top fo the Site Users listing and choose Edit New User Defaults. There are options for any Site Groups on that site that new users should be assigned to, and you will want to make sure that new users are at least assigned to the Everyone site group.