When ordering a kit does that user have to be in the site group for each item in the kit?

Yes, a user must have access to the products in the kit in order to be able to order them. A kit works as a group of products and while the user will be able to see the kit if they are in the same user group as the kit, they will not be able to order it.